refactoring GitSavvy settings and project-wise settings #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy3k
force-pushed
the
settings
branch
7 times, most recently
from
d1fa072
to
1498bc1
Compare
randy3k
changed the title
randy3k
force-pushed
the
settings
branch
4 times, most recently
from
1ce57a7
to
fe9c1e8
Compare
it is the first step towards project-wise settings
stoivo
reviewed
Apr 7, 2018
| @@ -61,3 +61,28 @@ class GsEditSettingsCommand(WindowCommand): | |||
| """ | |||
| def run(self, **kwargs): | |||
| self.window.run_command("edit_settings", kwargs) | |||
|
|
|||
There was a problem hiding this comment.
This should have been in the later commit but ¯_(ツ)_/¯
|
Looking good |
|
Though I have been using this branch for a while, I am still not 100% nothing breaks. However, let's merge it and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support of project-wise settings by refactoring settings related code.
A new command
Preference: GitSavvy Project Settingsis also added to allow easier editing.